Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Divider, Menu): replacing the gray12 from variables to gray08 #200

Merged
merged 2 commits into from
Sep 6, 2018

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Sep 6, 2018

Fix

The gray12 was deleted from the siteVariables which broke the look of the components using this color, as it was undefined. This was now replaced with gray08.

The components affected by this were the Divider (the border color for the default Divider) and the Menu (the bottom border color of the underined Menu).

@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files         103      103           
  Lines        1461     1461           
  Branches      288      288           
=======================================
  Hits          989      989           
  Misses        468      468           
  Partials        4        4
Impacted Files Coverage Δ
src/themes/teams/components/Menu/menuVariables.ts 50% <ø> (ø) ⬆️
...hemes/teams/components/Divider/dividerVariables.ts 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4697975...fdec216. Read the comment docs.

@mnajdova mnajdova merged commit b3467c4 into master Sep 6, 2018
@levithomason levithomason deleted the fix/missing-color-from-siteVars branch October 29, 2019 22:30
@levithomason levithomason restored the fix/missing-color-from-siteVars branch October 29, 2019 22:30
@levithomason levithomason deleted the fix/missing-color-from-siteVars branch October 29, 2019 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants