This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(whatInput): use proper document to set data-whatinput attr
#1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Sep 25, 2019
| if (event.target.classList && event.target.classList.length) { | ||
| docElem.setAttribute('data-whatclasses', event.target.classList.toString().replace(' ', ',')) | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't use data-whatclasses & data-whatelement, so it's safe to remove them
Codecov Report
@@ Coverage Diff @@
## master #1972 +/- ##
==========================================
+ Coverage 70.3% 70.37% +0.06%
==========================================
Files 894 894
Lines 7905 7889 -16
Branches 2314 2288 -26
==========================================
- Hits 5558 5552 -6
+ Misses 2334 2324 -10
Partials 13 13
Continue to review full report at Codecov.
|
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
reviewed
Sep 25, 2019
docs/src/examples/components/Provider/Usage/ProviderExampleTargetFrame.steps.ts
Outdated
Show resolved
Hide resolved
jurokapsiar
approved these changes
Sep 25, 2019
…x/what-input # Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1971.
This PR fixes our fork of
what-inputto properly setdata-whatinputattribute as our:focus-visibleimplementation dependents on it.