-
Notifications
You must be signed in to change notification settings - Fork 54
docs(props): put props on a single page, fix props links #1892
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
======================================
Coverage 69.9% 69.9%
======================================
Files 888 888
Lines 7775 7775
Branches 2244 2244
======================================
Hits 5435 5435
Misses 2330 2330
Partials 10 10 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
======================================
Coverage 69.9% 69.9%
======================================
Files 888 888
Lines 7775 7775
Branches 2244 2244
======================================
Hits 5435 5435
Misses 2330 2330
Partials 10 10 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
======================================
Coverage 70.3% 70.3%
======================================
Files 893 893
Lines 7894 7894
Branches 2311 2287 -24
======================================
Hits 5550 5550
Misses 2331 2331
Partials 13 13 Continue to review full report at Codecov.
|
It seems like we could fix this easier by just iterating all the props on a single page, opposed to having a dropdown to select the component props you want to see. Thoughts? |
I agree, that way the logic gets easier. I suggest we also have an outline of the components for which we have props. That is because the Props page can be long and it would be hard to navigate. @layershifter do you think we should get rid of the props dropdown and list all the props on a single page instead? |
Shift suggests that we could use a submenu of Props to list the various options. Something like: |
docs/src/components/ComponentDoc/ComponentProps/ComponentPropsOutline.tsx
Outdated
Show resolved
Hide resolved
docs/src/components/ComponentDoc/ComponentPropsTable/ComponentPropsRow.tsx
Show resolved
Hide resolved
docs/src/components/ComponentDoc/ComponentProps/ComponentPropsOutline.tsx
Outdated
Show resolved
Hide resolved
docs/src/components/ComponentDoc/ComponentProps/ComponentPropsOutline.tsx
Outdated
Show resolved
Hide resolved
docs/src/components/ComponentDoc/ComponentProps/ComponentProps.tsx
Outdated
Show resolved
Hide resolved
docs/src/components/ComponentDoc/ComponentProps/ComponentProps.tsx
Outdated
Show resolved
Hide resolved
docs/src/components/ComponentDoc/ComponentProps/ComponentPropCard.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Oleksandr Fediashov <[email protected]>
Fixes #1878. Furthermore, all props under one tab were collapsed on a single page, instead of having a dropdown prop selection.