This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
feat(Focus): focus indicator for additional documents #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
August 19, 2019 08:13
Codecov Report
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
- Coverage 69.74% 69.63% -0.12%
==========================================
Files 875 875
Lines 7519 7534 +15
Branches 2186 2220 +34
==========================================
+ Hits 5244 5246 +2
- Misses 2267 2280 +13
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also docElem
with calls like:
docElem.setAttribute(`data-whatinput`, currentInput)
docElem.setAttribute('data-whatelement', currentElement)
Should we also update it?
|
sophieH29
reviewed
Aug 19, 2019
layershifter
approved these changes
Aug 19, 2019
layershifter
pushed a commit
that referenced
this pull request
Aug 19, 2019
* focus indicator for additional documents * changelog * use document.defaultView * fix (cherry picked from commit 6a8864a)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event handlers that detect input type to additional documents as well