Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Focus): focus indicator for additional documents #1816

Merged
merged 5 commits into from
Aug 19, 2019

Conversation

jurokapsiar
Copy link
Contributor

Add event handlers that detect input type to additional documents as well

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #1816 into master will decrease coverage by 0.11%.
The diff coverage is 39.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1816      +/-   ##
==========================================
- Coverage   69.74%   69.63%   -0.12%     
==========================================
  Files         875      875              
  Lines        7519     7534      +15     
  Branches     2186     2220      +34     
==========================================
+ Hits         5244     5246       +2     
- Misses       2267     2280      +13     
  Partials        8        8
Impacted Files Coverage Δ
packages/react/src/lib/whatInput.ts 58.76% <38.46%> (-7.91%) ⬇️
...ackages/react/src/components/Provider/Provider.tsx 93.47% <50%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26fba7...f50b14b. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also docElem with calls like:

docElem.setAttribute(`data-whatinput`, currentInput)
docElem.setAttribute('data-whatelement', currentElement)

Should we also update it?

@jurokapsiar
Copy link
Contributor Author

Should we also update it?
Agreed offline to handle it separately.

@layershifter layershifter merged commit 6a8864a into master Aug 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/document-focus branch August 19, 2019 11:15
layershifter pushed a commit that referenced this pull request Aug 19, 2019
* focus indicator for additional documents

* changelog

* use document.defaultView

* fix

(cherry picked from commit 6a8864a)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants