This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dialog|Segment): update support of color prop
#1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
…x/segment-dialog-interfactes
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 858 858
Lines 7106 7106
Branches 2033 2033
=======================================
Hits 5058 5058
Misses 2042 2042
Partials 6 6
Continue to review full report at Codecov.
|
mnajdova
approved these changes
Jul 22, 2019
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://stardust-react-git-fix-segment-dialog-interfactes.stardust-ui.now.sh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked from #1670.
Dialognever had support ofcolorprop, so I removed it fromDialogSegmenthad support, but typings were not complete, so I added them