This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Provider): add ProviderBoxProps and div attributes to ProviderProps #1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider
by default rendersProviderBox
which by default renders adiv
.child props
Provider
only acceptedProviderProps
. It was not possible to pass anyProviderBox
props (likestyles
) ordiv
attributes (likeid
).Now it accepts all of these.
theme
propPreviously,
theme
was required prop. But as new props were added to theProvider
, it now makes sense to instantiate theProvider
without thetheme
just changing other params (rtl
).This PR makes
theme
optional.This still does not make sense for top level provider but there already is a runtime check for that.
Fixes #1424.