This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
fix(ChatMessage): action menu doesn't disappear on click #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
July 8, 2019 11:33
mnajdova
changed the title
[
[WIP] fix(ChatMessage): action menu doesn't disappear on click
Jul 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
==========================================
- Coverage 71.53% 71.47% -0.07%
==========================================
Files 848 848
Lines 6932 6938 +6
Branches 1997 2003 +6
==========================================
Hits 4959 4959
- Misses 1967 1973 +6
Partials 6 6
Continue to review full report at Codecov.
|
mnajdova
changed the title
[WIP] fix(ChatMessage): action menu doesn't disappear on click
fix(ChatMessage): action menu doesn't disappear on click
Jul 8, 2019
mnajdova
commented
Jul 10, 2019
docs/src/prototypes/chatMessages/ChatMessageWithPopover/ReactionPopup.tsx
Outdated
Show resolved
Hide resolved
mnajdova
commented
Jul 10, 2019
docs/src/prototypes/chatMessages/ChatMessageWithPopover/ChatWithPopover.tsx
Outdated
Show resolved
Hide resolved
-updated changelog
mnajdova
commented
Jul 11, 2019
@@ -18,11 +17,5 @@ export default () => ( | |||
> | |||
<ImportantAndMentionMessages /> | |||
</ComponentPrototype> | |||
<ComponentPrototype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this prototype as the reactions with popup is already included in the first one
kuzhelov
reviewed
Jul 11, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
jurokapsiar
reviewed
Jul 11, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jul 11, 2019
docs/src/prototypes/chatMessages/ChatMessageWithPopover/Popover.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jul 11, 2019
docs/src/prototypes/chatMessages/ChatMessageWithPopover/Popover.tsx
Outdated
Show resolved
Hide resolved
…to fix/chat-message-action-menu
kuzhelov
reviewed
Jul 11, 2019
kuzhelov
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action menu on the ChatMessages in Teams theme, should be open or closed based on the user interaction with the options within. For example, clicking on the emoticons, should close it, but clicking on the '...' should leave it open for the client to be able to choose one of the options.
For this to be possible, we need to allow the user to control this in some way. Currently the showing/hiding of the action menu is done only by changing the opacity of it, based on the state's focused prop. The simplest way to allow the user to control this is adding a boolean variable that can alter these styles -
showActionMenu
. In the future, if we decide that adding/hiding the action menu is a common thing, we may make this component AutoControlled and change it via the props.In my opinion this is the simplest way of fixing the issue, but we still need to make insure that we are not breaking any of the prev accessibility. @sophieH29 @jurokapsiar can we test this and ensure that the focusing behavior is still working as expected?