Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Toolbar): Add toolbarBehavior and toolbarItemBehavior #1468

Merged
merged 12 commits into from
Jun 18, 2019

Conversation

sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Jun 7, 2019

closes #1413

  • improved buttonBehavior
  • improved toggleButtonBehavior
  • added toolbarItemBehavior

@sophieH29 sophieH29 added ⚙️ enhancement New feature or request 🚀 ready for review accessibility All the Accessibility tasks and bugs should be tagged with this. labels Jun 7, 2019
@sophieH29 sophieH29 self-assigned this Jun 7, 2019
Sofiya Huts and others added 3 commits June 10, 2019 17:52
# Conflicts:
#	packages/react/src/lib/accessibility/Behaviors/Button/buttonBehavior.ts
#	packages/react/src/lib/accessibility/Behaviors/Button/toggleButtonBehavior.ts
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1468 into master will decrease coverage by 0.02%.
The diff coverage is 68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1468      +/-   ##
=========================================
- Coverage   73.23%   73.2%   -0.03%     
=========================================
  Files         822     823       +1     
  Lines        6198    6221      +23     
  Branches     1802    1805       +3     
=========================================
+ Hits         4539    4554      +15     
- Misses       1654    1662       +8     
  Partials        5       5
Impacted Files Coverage Δ
packages/react/src/index.ts 100% <ø> (ø) ⬆️
packages/react/src/components/Button/Button.tsx 80% <0%> (-10.91%) ⬇️
...kages/react/src/components/Toolbar/ToolbarItem.tsx 73.91% <0%> (-11.09%) ⬇️
packages/react/src/components/Toolbar/Toolbar.tsx 89.47% <0%> (-10.53%) ⬇️
...ssibility/Behaviors/Button/toggleButtonBehavior.ts 100% <100%> (ø) ⬆️
...accessibility/Behaviors/Toolbar/toolbarBehavior.ts 100% <100%> (ø)
...ages/react/test/specs/behaviors/testDefinitions.ts 91.13% <100%> (+0.34%) ⬆️
...b/accessibility/Behaviors/Button/buttonBehavior.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bd725...9c2388f. Read the comment docs.

# Conflicts:
#	packages/react/src/components/Toolbar/ToolbarItem.tsx
@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@sophieH29 sophieH29 merged commit 2761231 into master Jun 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/toolbar-behavior branch June 18, 2019 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility All the Accessibility tasks and bugs should be tagged with this. ⚙️ enhancement New feature or request ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar - accessibility behavior
5 participants