draft: enhancement-322-Add-retry-mechanism-for-the-given-error #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thelin90
force-pushed
the
enhancement-322-Add-retry-mechanism-for-the-given-error
branch
from
14557b0
to
6929e02
Compare
hovaesco
reviewed
Jul 12, 2023
| sql: str, | ||
| auto_begin: bool = False, | ||
| fetch: bool = False, | ||
| max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS, |
There was a problem hiding this comment.
trino.constants.DEFAULT_MAX_ATTEMPTS is for connection timeout issues
| auto_begin: bool = False, | ||
| fetch: bool = False, | ||
| max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS, | ||
| retry_delay: int = 1, |
There was a problem hiding this comment.
@dataders can we pass a specific error message, retry_delay and max_retries from model configuration to here?
3 tasks
|
I have created a dbt-core issue that is probably relevant: dbt-labs/dbt-adapters#226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
resolves #322
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry