Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab shows different content when switching from another tab. #145

Open
dmitry-buzzwoo opened this issue Jan 24, 2024 · 19 comments
Open

Tab shows different content when switching from another tab. #145

dmitry-buzzwoo opened this issue Jan 24, 2024 · 19 comments

Comments

@dmitry-buzzwoo
Copy link

dmitry-buzzwoo commented Jan 24, 2024

Screen.Recording.2024-01-24.at.11.27.14.mov
@staniel359
Copy link
Owner

@dmitry-buzzwoo Hello.
This is very weird.
Added to planned.

@staniel359 staniel359 self-assigned this Jan 24, 2024
@staniel359 staniel359 added the bug label Jan 24, 2024
@xyloflake
Copy link
Contributor

@staniel359 this is a memory infrastructure bug. I don’t think you’ll be able to solve this. Please asssign me this one.

@xyloflake
Copy link
Contributor

@dmitry-buzzwoo does this always happen? Are there specific repro steps?

@staniel359
Copy link
Owner

@xyloflake Why is it a memory issue?
I assume it's a Vue's cached pages bug.

@xyloflake
Copy link
Contributor

@staniel359 please explain the logic used for keeping tabs separate on muffon in discord DMs.

I suspect this is a memory issue because there are some memory leaks I recently discovered in the code responsible for BrowserView.

@dmitry-buzzwoo
Copy link
Author

@xyloflake I had this problem when I switched from YouTube playlist tab to a video tab. This is the only details I can tell you about.

@dmitry-buzzwoo
Copy link
Author

Also, another unrelated issue is when I use hot key "cmd+r" to update the tab, all tabs are being updated.

@xyloflake
Copy link
Contributor

@xyloflake I had this problem when I switched from YouTube playlist tab to a video tab. This is the only details I can tell you about.

Thanks. @staniel359 @gamersi can you guys try reproducing the bug?

@xyloflake
Copy link
Contributor

Also, another unrelated issue is when I use hot key "cmd+r" to update the tab, all tabs are being updated.

That's expected. @staniel359 uses BrowserView to implement tabs. They're not in reality tabs, they're just Out Of Process Iframes. That means all the tabs exist in a single webpage. When you hit Ctrl/Cmd+R, you're triggering the whole webpage to reload, thus reloading all the tabs in existence.

@dmitry-buzzwoo
Copy link
Author

dmitry-buzzwoo commented Jan 25, 2024

I see, but I suppose in theory it's possible? There is a "refresh" button which reloads just an active tab. I think it's possible to track the currently active tab on "cmd+r" interception and refresh the only active tab like the "refresh" button does?

That's up to you. But I think it will just improve UX.

@dmitry-buzzwoo
Copy link
Author

btw, refreshing the tab that shows an incorrect content (video instead of playlist) doesn't help. To show the correct content, I have to switch to another tab first and then switch back.

@staniel359
Copy link
Owner

@dmitry-buzzwoo Page reloading shouldn't work via shortcuts.
Could you send a video of this behavior?

@dmitry-buzzwoo
Copy link
Author

Screen.Recording.2024-01-25.at.16.11.10.mov

@xyloflake
Copy link
Contributor

@staniel359 what's with the horrendous loading speed?

@staniel359
Copy link
Owner

@xyloflake It's basically 6 Electron instances loading at once.

@xyloflake
Copy link
Contributor

@dmitry-buzzwoo may I know your mac specs please?

@dmitry-buzzwoo
Copy link
Author

dmitry-buzzwoo commented Jan 29, 2024

@xyloflake sure:

Model Name: MacBook Air
Model Identifier: Mac14,2
Chip: Apple M2
Total Number of Cores: 8 (4 performance and 4 efficiency)
Memory: 16 GB
System Firmware Version: 10151.61.4
OS Loader Version: 10151.61.4
System Version: macOS 14.2.1 (23C71)
Kernel Version: Darwin 23.2.0
Boot Volume: Macintosh HD
Boot Mode: Normal

@xyloflake
Copy link
Contributor

@staniel359 this is too slow for such a powerful machine.

@staniel359
Copy link
Owner

@dmitry-buzzwoo Have you encountered this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants