-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab shows different content when switching from another tab. #145
Comments
@dmitry-buzzwoo Hello. |
@staniel359 this is a memory infrastructure bug. I don’t think you’ll be able to solve this. Please asssign me this one. |
@dmitry-buzzwoo does this always happen? Are there specific repro steps? |
@xyloflake Why is it a memory issue? |
@staniel359 please explain the logic used for keeping tabs separate on muffon in discord DMs. I suspect this is a memory issue because there are some memory leaks I recently discovered in the code responsible for BrowserView. |
@xyloflake I had this problem when I switched from YouTube playlist tab to a video tab. This is the only details I can tell you about. |
Also, another unrelated issue is when I use hot key "cmd+r" to update the tab, all tabs are being updated. |
Thanks. @staniel359 @gamersi can you guys try reproducing the bug? |
That's expected. @staniel359 uses BrowserView to implement tabs. They're not in reality tabs, they're just Out Of Process Iframes. That means all the tabs exist in a single webpage. When you hit Ctrl/Cmd+R, you're triggering the whole webpage to reload, thus reloading all the tabs in existence. |
I see, but I suppose in theory it's possible? There is a "refresh" button which reloads just an active tab. I think it's possible to track the currently active tab on "cmd+r" interception and refresh the only active tab like the "refresh" button does? That's up to you. But I think it will just improve UX. |
btw, refreshing the tab that shows an incorrect content (video instead of playlist) doesn't help. To show the correct content, I have to switch to another tab first and then switch back. |
@dmitry-buzzwoo Page reloading shouldn't work via shortcuts. |
Screen.Recording.2024-01-25.at.16.11.10.mov |
@staniel359 what's with the horrendous loading speed? |
@xyloflake It's basically 6 Electron instances loading at once. |
@dmitry-buzzwoo may I know your mac specs please? |
@xyloflake sure: Model Name: MacBook Air |
@staniel359 this is too slow for such a powerful machine. |
@dmitry-buzzwoo Have you encountered this again? |
Screen.Recording.2024-01-24.at.11.27.14.mov
The text was updated successfully, but these errors were encountered: