Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: macos-11 image uses 10.9 wheels #369

Closed
ahartikainen opened this issue Oct 7, 2022 · 13 comments
Closed

ci: macos-11 image uses 10.9 wheels #369

ahartikainen opened this issue Oct 7, 2022 · 13 comments
Labels

Comments

@ahartikainen
Copy link
Contributor

Describe the bug

For some reason macos11 images in ci pipeline use 10.9 wheels with pip.

Describe your system

Github Actions

Steps/Code to Reproduce

@ahartikainen
Copy link
Contributor Author

For some reason on macos-11image

python -c "from distutils import util;print(util.get_platform())"
# macosx-10.15-x86_64

And just to be sure

python -c "from setuptools._distutils import util;print(util.get_platform())"
# macosx-10.15-x86_64

@ahartikainen ahartikainen changed the title ci: macos11 uses 10.9 wheels ci: macos-11 image uses 10.9 wheels Oct 8, 2022
@riddell-stan
Copy link
Contributor

Is macos 11 refusing to install wheels built using older versions of macos? I thought macos wheels built on older systems would work on newer os versions.

@ahartikainen
Copy link
Contributor Author

ahartikainen commented Oct 8, 2022

I think on macos-11 image in github actions the python is refusing to install newer (gh actions10.x vs pypi 11) wheels.

httpstan macos-11 ci also creates 10.x wheel for local use, but httpstan-wheels repo creates the correct 11 wheel.

@ahartikainen
Copy link
Contributor Author

Ok, I wonder if GH actions use the same python binary for macos10 and macos11?

@ahartikainen
Copy link
Contributor Author

I guess this is somehow related

actions/python-versions#114

@riddell-stan
Copy link
Contributor

Let's fix this problem first. We could also build a Python 3.11 wheel in httpstan-wheels while we are at it.

@riddell-stan
Copy link
Contributor

It's just macos-11, 3.10. macos-11, 3.9 seems to work fine.

@ahartikainen
Copy link
Contributor Author

Yes, we need to address this first.

So 3.9 and 3.8 has macos 10.16 wheels.
3.10 has macos 11.0.

https://pypi.org/project/httpstan/#files

And the python on GH Actions thinks it is macos 10.15.

So any 10.x works but 11.x does not?

@riddell-stan
Copy link
Contributor

So why can't macos 11.0 (Python 3.10) install the PyPI wheel httpstan-4.8.2-cp310-cp310-macosx_11_0_x86_64.whl? Looks compatible to me!

@riddell-stan
Copy link
Contributor

Perhaps we should try to build a Python 3.10 wheel on an older macos version in httpstan-wheels?

@ahartikainen
Copy link
Contributor Author

That might be a solution.

I bet pip tool somehow fails with 10.x vs 11.x (major.minor) difference given major number difference.

@riddell-stan
Copy link
Contributor

I think I've figured it out. Setting ARCHFLAGS to x86_64 did the trick. Now I'm able to build httpstan-4.8.2-cp310-cp310-macosx_10_15_x86_64.whl. See stan-dev/httpstan-wheels#92

@riddell-stan
Copy link
Contributor

Fixed in httpstan-wheels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants