Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update angular monorepo to v14 (major) #663

Merged
merged 3 commits into from
Aug 20, 2022

Conversation

floross
Copy link
Contributor

@floross floross commented Aug 17, 2022

The goal of this pr is to update angular to 14 and be able to use casl with the last main version of angular

Closes #661

@floross floross force-pushed the update-angular-14 branch from 98ff2e5 to c5c1d94 Compare August 17, 2022 05:33
@floross floross force-pushed the update-angular-14 branch from c5c1d94 to de42041 Compare August 17, 2022 05:33
@floross floross changed the title feat: bump angular to 14 chore(deps): bump angular to 14 Aug 17, 2022
@floross floross changed the title chore(deps): bump angular to 14 chore(deps): update angular monorepo to v14 (major) Aug 17, 2022
@stalniy
Copy link
Owner

stalniy commented Aug 17, 2022

This is probably a breaking change. Because ivy generated lib I guess won’t work with View Engine

@floross
Copy link
Contributor Author

floross commented Aug 17, 2022

What should I do to help then ? I tried to upgrade to angular 14 but no tests has break.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #663 (6f9dedc) into master (e174b87) will increase coverage by 1.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   93.71%   94.97%   +1.25%     
==========================================
  Files          32       32              
  Lines         716      716              
  Branches      174      174              
==========================================
+ Hits          671      680       +9     
- Misses         13       18       +5     
+ Partials       32       18      -14     
Impacted Files Coverage Δ
packages/casl-mongoose/src/accessible_fields.ts 100.00% <ø> (+4.76%) ⬆️
packages/casl-mongoose/src/accessible_records.ts 84.00% <100.00%> (+4.00%) ⬆️
packages/casl-mongoose/src/mongo.ts 100.00% <100.00%> (ø)
packages/casl-ability/src/RuleIndex.ts 94.87% <0.00%> (ø)
...ckages/casl-prisma/src/prisma/PrismaQueryParser.ts 93.84% <0.00%> (ø)
packages/casl-ability/src/extra.ts 93.24% <0.00%> (+1.35%) ⬆️
packages/casl-vue/src/component/can.ts 100.00% <0.00%> (+3.70%) ⬆️
packages/casl-react/src/Can.ts 92.30% <0.00%> (+3.84%) ⬆️
packages/casl-ability/src/ForbiddenError.ts 88.46% <0.00%> (+3.84%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stalniy stalniy merged commit e556f14 into stalniy:master Aug 20, 2022
@stalniy
Copy link
Owner

stalniy commented Aug 20, 2022

published in @casl/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a plan to update angular to v14 ?
3 participants