Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store file content in memory #83

Open
allejo opened this issue Nov 5, 2018 · 1 comment
Open

Don't store file content in memory #83

allejo opened this issue Nov 5, 2018 · 1 comment
Labels
Core: Breaking This will require a large change to the project's internals; save this for major releases Difficulty: Difficult Something that will take a weekend to fix or involves a lot of internal changes Feature: Enhancement The feature already exists but this is a request for it to be improved
Milestone

Comments

@allejo
Copy link
Member

allejo commented Nov 5, 2018

Whenever the file is read in as a FrontMatterDocument, the file's contents are stored in memory as $this->bodyContent. The more files that are parsed, the more that is being stored.

I want to explore changing this behavior to reading in the body of the files only when the DevServer needs it; the FrontMatter will still be read in and stored but the body will be thrown away until it's needed again.

For a regular build, however, the Compiler should store things in memory for faster performance.

@allejo allejo added Feature: Enhancement The feature already exists but this is a request for it to be improved Core: Breaking This will require a large change to the project's internals; save this for major releases Difficulty: Difficult Something that will take a weekend to fix or involves a lot of internal changes labels Nov 5, 2018
@allejo allejo added this to the v0.2.0 milestone Nov 5, 2018
@allejo
Copy link
Member Author

allejo commented Apr 14, 2019

Since this is likely going to be a very invasive change with how stakx core works and we're in a feature freeze for 0.2.0. I'll move this to the next major release.

@allejo allejo modified the milestones: v0.2.0, v0.3.0 Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: Breaking This will require a large change to the project's internals; save this for major releases Difficulty: Difficult Something that will take a weekend to fix or involves a lot of internal changes Feature: Enhancement The feature already exists but this is a request for it to be improved
Projects
None yet
Development

No branches or pull requests

1 participant