Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Japanese Presamp Phonemizer] Add option for MUSTVC #975

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

lottev1991
Copy link
Contributor

This makes it so that when [MUSTVC] is set to 1 in the presamp.ini file, a VC phoneme will be inserted even on short notes. When set to 0 (which is the default), this will not happen.

@Michelino98
Copy link

Michelino98 commented Dec 9, 2023

@lottev1991 Would this be able to fix the missing VCs from phonemizers? glad it was taken care but how can I do it? a tutorial would be much apprecieted. (^ ^ )

@lottev1991
Copy link
Contributor Author

@lottev1991 Would this be able to fix the missing VCs from phonemizers? glad it was taken care but how can I do it? a tutorial would be much apprecieted. (^ ^ )

I don't know what you mean with "phonemizers" as this PR only applies to one specific phonemizer. This function never existed in any of the other phonemizers in the first place.

@Michelino98
Copy link

Michelino98 commented Dec 10, 2023

Oh I Apologize, I'm refering the Phonemizer in plural since in OU their are called like: [JA CVVC] Japanese CVVC Phonemizer, [EN VCCV] English Phonemizer, along with the contributor in paretesis and so on. Felt like their multiple Phonemizer. to the Issue that I'm refering here's the link: #970
I might made into a mess of examplanation but it shows my probleam. And gonna be honest I mainly use mostly the JA VCV&CVVC Presamp Phonemizer hehe and also I was flabbergasted by seeing the appends's VC not showing.

@lottev1991
Copy link
Contributor Author

Oh I Apologize, I'm refering the Phonemizer in plural since in OU their are called like: [JA CVVC] Japanese CVVC Phonemizer, [EN VCCV] English Phonemizer, along with the contributor in paretesis and so on. Felt like their multiple Phonemizer. to the Issue that I'm refering here's the link: #970 I might made into a mess of examplanation but it shows my probleam. And gonna be honest I mainly use mostly the JA VCV&CVVC Presamp Phonemizer hehe and also I was flabbergasted by seeing the appends's VC not showing.

The issue you've linked to seems to be unrelated to this PR.

@stakira stakira merged commit a444156 into stakira:master Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants