Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved stability of rendering #952

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

maiko3tattun
Copy link
Contributor

Changes:

  • Fixed parent methods could not know exceptions handled by deep methods
  • Fixed double display of error dialog due to catching and re-throwing exceptions several times
  • Fixed UI thread cannot catch exceptions because playback is an asynchronous process

Verified:

  • When exceptions is thrown during pre-rendering, write error in log without error dialog
  • When exceptions is thrown during playback, show an error dialog and stop playback
  • When exceptions is thrown during export of mixdown or tracks, show an error dialog and do not export

@stakira stakira merged commit 1edad5f into stakira:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants