Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests introduced or changed in pull requests are not run in the CI builds #250

Closed
d3adb5 opened this issue Apr 15, 2023 · 0 comments · Fixed by #251
Closed

Unit tests introduced or changed in pull requests are not run in the CI builds #250

d3adb5 opened this issue Apr 15, 2023 · 0 comments · Fixed by #251
Labels
bug

Comments

@d3adb5
Copy link
Collaborator

d3adb5 commented Apr 15, 2023

Currently, the checkout action in the unittests job of our GitHub Actions workflow is not actually running tests from the pull request head, instead running the ones on their base branch, master.

This leads to PRs that break unit tests passing the status check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: run unit tests from the pr head d3adb5/application
1 participant
@d3adb5