Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish vehicle speed through ferrostar core #273

Closed
Archdoog opened this issue Sep 26, 2024 · 2 comments
Closed

Publish vehicle speed through ferrostar core #273

Archdoog opened this issue Sep 26, 2024 · 2 comments
Labels
core Related to the Rust core

Comments

@Archdoog
Copy link
Collaborator

Archdoog commented Sep 26, 2024

To leverage any future location provider enhancements, we should publish a uniffied device speed through the location provider and state. This will allow a simple default implementation in the views as noted with #247

Created this so #89 can be closed with the current annotations MR #261

@Archdoog Archdoog added the core Related to the Rust core label Sep 26, 2024
@ianthetechie
Copy link
Contributor

What needs to be added here exactly? This is already part of the UserLocation struct which is published from the LocationProvider implementers (and contains GPS speed, not the less accurate derived speed; I should document that more clearly perhaps?).

It also ends up in TripState indirectly through SnappedLocation, but IMO this is better to get either directly from the location provider or, if needed in the UI, it of course ends up in UI state. On iOS, this would be accessible via snapped location, and on Android we now bubble up the "raw" location (which is more obvious than the snapped one) in the UI state as of #250.

TL;DR, I think this is already published, we can make views today based on the Speed model, and any UserLocation should already be publishing the more accurate speed info derived from GPS.

@Archdoog
Copy link
Collaborator Author

That should work, I think this may be more of an implementation detail of our dynamic zoom (and whatever else). Similar to the annotation publisher as seen in #287. I just didn't want to have to combine a bunch of source data to make use of speed and navigation state 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the Rust core
Projects
Status: Done
Development

No branches or pull requests

2 participants