-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed parsing for node #66
fix: fixed parsing for node #66
Conversation
…cation in brackets
…edLine' and 'location'
@Aleksey28 I wanted to follow up - I haven't had a chance to closely review this - but I would love to merge. Is this ready to go? I see you haven't checked off two checkboxes in the checklist above (docs and running that script without errors). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment (you didn't check off two checkboxes yet in the GH issue template).
@niftylettuce Yes, it's ready to go. I haven't checked because they're unnecessary and they just were in the template of the PR. I think it outdated checkboxes
|
Ping @eriwen for npm owner access so I can publish v2.0.7 via |
v2.0.7 published, thanks again @eriwen 🙏 cc @Aleksey28 https://github.com/stacktracejs/error-stack-parser/releases/tag/v2.0.7 |
Description
Motivation and Context
I have a problem with the Node.js product. In some ways error looks like this:
First-line doesn't have a function name and round brackets and it loses full file name after splitting.
How Has This Been Tested?
Added new option for test 'should handle spaces in Node.js stacks'
Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc error-stack-parser.js
passes without errorsnpm test
passes without errors