Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using and adminpassword via Env Var #47

Open
wileyj opened this issue Mar 23, 2021 · 1 comment
Open

Support for using and adminpassword via Env Var #47

wileyj opened this issue Mar 23, 2021 · 1 comment
Assignees

Comments

@wileyj
Copy link
Contributor

wileyj commented Mar 23, 2021

Rather than using a hardcoded adminPassword in the config file like :

  adminPassword: 'NEEDS-A-PASSWORD',

It would be better to use an env if present: ADMIN_PASSWORD="my-fake-password".

This would prevent adding an admin password in plain-text, similar to how the payment & owner keys are handled.

https://github.com/blockstack/subdomain-registrar/blob/master/src/config.js#L53

@wileyj
Copy link
Contributor Author

wileyj commented Mar 23, 2021

@hstove something like this should work i think:
0b091b1

@wileyj wileyj mentioned this issue Apr 9, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants