Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in signer block validation #5718

Open
obycode opened this issue Jan 16, 2025 · 0 comments
Open

Race condition in signer block validation #5718

obycode opened this issue Jan 16, 2025 · 0 comments

Comments

@obycode
Copy link
Contributor

obycode commented Jan 16, 2025

After #5453 implemented the system to handle re-sending a block for validation if the signer gets a 429 response, there is some new flaky behavior in the tests. It is not likely to be a problem outside of tests, because it is considered bad practice to have multiple signers attached to one stacks-node, but in many of our tests, there are five signers on one node. The problem shows up like this:

  • Signer 3 receives the block proposal and submits it for validation
  • Signer 2 receives the block validation response
    • It has not yet seen the proposal so it ignores the response
  • Signer 2 receives the block proposal
    • It submits it for validation
    • Receives a 429 response -- the node is still in the process of sending the validation event to the other signers
    • Inserts this block proposal into the database to try later
  • Signer 2 never tries again later because it never sees another response
  • Test times out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

1 participant