Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Request: Require all checks to pass on PRs #5687

Open
kantai opened this issue Jan 13, 2025 · 3 comments
Open

CI Request: Require all checks to pass on PRs #5687

kantai opened this issue Jan 13, 2025 · 3 comments

Comments

@kantai
Copy link
Member

kantai commented Jan 13, 2025

Currently, all tests (except for Clippy, which is fixed in my PR #5678) pass eventually in develop -- there are still a handful of flaky tests, but they can be re-run to get them to pass.

Getting all of them to pass should be a requirement for entering the merge queue: we've had a handful of PRs get through to develop which broke E2E tests, and we should stop doing that.

@kantai
Copy link
Member Author

kantai commented Jan 14, 2025

@wileyj

@jcnelson
Copy link
Member

Seconded. Now that Nakamoto is out, this is a great time to adopt healthy code hygiene habits like this.

@wileyj
Copy link
Contributor

wileyj commented Jan 15, 2025

this is enabled on a few branches as of today. running the release tests as well and will file issues to fix or remove from those workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

3 participants