🚚 Rename burn_chain_tip to burnchain_tip

[r0zar]

Incremental refactor PR to clean up deprecated variable name.

Description

Rename burn_chain_tip to burnchain_tip to normalize naming conventions

Applicable issues

• Replace burn_chain/burn chain with burnchain #2779

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[CLAassistant]

All committers have signed the CLA.

[igorsyl]

Thanks for helping make our code base better!

[codecov]

Codecov Report

Merging #3598 (7977860) into master (9f7a650) will decrease coverage by 1.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   31.23%   30.24%   -1.00%     
==========================================
  Files         298      298              
  Lines      275069   275069              
==========================================
- Hits        85923    83196    -2727     
- Misses     189146   191873    +2727     

Impacted Files	Coverage Δ
src/burnchains/burnchain.rs	73.79% <75.00%> (-0.17%)	⬇️
testnet/stacks-node/src/tests/neon_integrations.rs	63.39% <0.00%> (-23.98%)	⬇️
testnet/stacks-node/src/tests/epoch_205.rs	80.18% <0.00%> (-17.97%)	⬇️
...mon/src/deps_common/bitcoin/blockdata/constants.rs	36.76% <0.00%> (-8.83%)	⬇️
testnet/stacks-node/src/event_dispatcher.rs	78.42% <0.00%> (-5.22%)	⬇️
...ommon/src/deps_common/bitcoin/network/serialize.rs	40.00% <0.00%> (-5.00%)	⬇️
src/chainstate/stacks/db/contracts.rs	38.46% <0.00%> (-3.85%)	⬇️
src/chainstate/burn/db/mod.rs	37.03% <0.00%> (-3.71%)	⬇️
testnet/stacks-node/src/tests/mod.rs	51.64% <0.00%> (-3.70%)	⬇️
stacks-common/src/util/macros.rs	78.00% <0.00%> (-2.80%)	⬇️
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jferrant]

Looks like a good start! I like how you have kept your commits small/single change for easy review :) Look forward to seeing further commits/updates to the pull request!

[igorsyl]

Please use: https://github.com/stacks-network/stacks-blockchain/wiki/How-to-Create-and-Review-PRs

[jio-gl]

all tests passed, a variable was renamed.

[jcnelson]

This looks fine to me; will approve when it's no longer a draft.

[r0zar]

Since we've already got some 👀 on this- I'd like to see this PR through the code review / merge process while it's still small and low-risk. This will provide a great learning opportunity for me as this happens to be my first PR on the stack-blockchain repository.

[r0zar]

Rebased and ready for approval review. ✔️

[jcnelson]

One of us will need to merge this into a fix/ branch so that the build CI steps will pass.