Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include default plugins #36

Open
yoshuawuyts opened this issue Jan 17, 2016 · 6 comments
Open

include default plugins #36

yoshuawuyts opened this issue Jan 17, 2016 · 6 comments

Comments

@yoshuawuyts
Copy link
Contributor

From #32 (comment)

an open question is whether we specify any default plugins, such as what css-modulesify does. specifically i'm thinking of postcss-import, perhaps also a way to pass values around (like this but in our own way).

I reckon including postcss-import is a good call; if any other plugins should be included too this would be the right place to discuss.

@yoshuawuyts
Copy link
Contributor Author

Hmm, css-variables could perhaps be a solution to this? - it'd be cool if variables would trickle through to child nodes; perhaps with a global flag set or smth

@yoshuawuyts
Copy link
Contributor Author

Perhaps if a stylesheet is imported / declared, but not defined to a variable (e.g. prefix) it is treated as global - intentionally, because no prefix is being used. Do you reckon that's sane behavior?

@yoshuawuyts
Copy link
Contributor Author

Alright so postcss-import is not going to fly - even though it's a sync operation, it presumes it's async and starts doing hairy .then() stuff.

Given that we already have syntax for to solve this e.g.

sheetify('module-from-npm')

I don't think there's a need to include this plugin specifically.

I'm going to close this issue for now, as it's holding up a v4 release - going to add tests for module imports tho, as they're not currently being tested I believe.

If any other plugins should perhaps be included, I reckon we should open separate issues for that. Thanks!

@yoshuawuyts yoshuawuyts mentioned this issue Feb 10, 2016
5 tasks
@yoshuawuyts
Copy link
Contributor Author

Reviving this, as it can be useful for more complex css libs to split up their deps into multiple files (see css-wipe).

This does require that index.js performs actions in an async fashion, as PostCSS decided to support async calls for their api - postcss/postcss-import#41 - big fat refactor is needed for this to work.

@bcomnes
Copy link
Contributor

bcomnes commented Oct 2, 2016

I would personally prefer if sheetify didn't come with a lot of plugins. It would be better if you could add them in as you need them with sheetify-postcss.

@yoshuawuyts
Copy link
Contributor Author

@bcomnes yup on board with you here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants