Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other NifiClusters to reconcile even if one is invalid #662

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 8, 2024

Description

Spike for stackabletech/issues#211. Blocked on kube-rs 0.94.0 being released (and us upgrading to it).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@nightkr nightkr marked this pull request as ready for review October 2, 2024 10:09
@nightkr nightkr requested review from a team and removed request for a team October 2, 2024 10:09
@adwk67 adwk67 requested review from adwk67 and removed request for a team October 7, 2024 11:37
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nightkr nightkr enabled auto-merge October 7, 2024 13:18
@nightkr nightkr added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 2a76c18 Oct 7, 2024
31 checks passed
@nightkr nightkr deleted the feature/deserializeguard branch October 7, 2024 13:26
@lfrancke
Copy link
Member

Do we have an overarching tracking issue to do the same for all other operators?

@nightkr
Copy link
Member Author

nightkr commented Oct 10, 2024

Arguably stackabletech/issues#211, but I can also see us reasonably saying that that was the research issue and now we should make a separate rollout issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants