Add non-streaming download option to address Payload Incomplete issue

[drnextgis]

stac-asset utilizes the Streaming API, but it occasionally encounters the "Response payload is not completed" issue, which the aiohttp team is aware of. Do you think it would be worthwhile to introduce an alternative (non-streaming based) method for downloading assets, even if it means loading them into memory?

stac_asset.errors.DownloadError: ClientPayloadError: Response payload is not completed: <ContentLengthError: 400, message='Not enough data for satisfy content length header.'>

[gadomski]

Do you think it would be worthwhile to introduce an alternative (non-streaming based) method for downloading assets, even if it means loading them into memory?

I don't see any harm in providing that option ... it'd probably be additional logic in download_href, e.g. an additional argument that would read the entire file into memory instead of iterating over its bytes:

stac-asset/src/stac_asset/client.py

Lines 83 to 120 in e295611

	async def download_href(
	self,
	href: str,
	path: PathLikeObject,
	clean: bool = True,
	content_type: Optional[str] = None,
	messages: Optional[MessageQueue] = None,
	) -> None:
	"""Downloads a file to the local filesystem.
	Args:
	href: The input href
	path: The output file path
	clean: If an error occurs, delete the output file if it exists
	content_type: The expected content type
	messages: An optional queue to use for progress reporting
	"""
	try:
	async with aiofiles.open(path, mode="wb") as f:
	async for chunk in self.open_href(
	href, content_type=content_type, messages=messages
	):
	await f.write(chunk)
	if messages:
	try:
	messages.put_nowait(
	WriteChunk(href=href, path=Path(path), size=len(chunk))
	)
	except QueueFull:
	pass
	except Exception as err:
	path_as_path = Path(path)
	if clean and path_as_path.exists():
	try:
	path_as_path.unlink()
	except Exception:
	pass
	raise err