Jc/responseencoder #22
Conversation
…ns to be stopped.
| reflectedThat.type.declarations.values.where((dm) => dm is VariableMirror).forEach((VariableMirror vm) { | ||
| reflectedThis.setField(vm.simpleName, reflectedThat.getField(vm.simpleName).reflectee); | ||
| }); | ||
| } |
There was a problem hiding this comment.
This is pretty cool, but it seems kinda dangerous.
There was a problem hiding this comment.
How so? I realized it was more dangerous when I was setting each property individually, added a new property, and it wasn't showing up on the other end of the pipeline.
There was a problem hiding this comment.
I'm worried about the implicit assumption that all of the properties are copied on assignment.
There was a problem hiding this comment.
Ok nvm I looked at how its being used.
There was a problem hiding this comment.
actually, that brings up a good point: there really isn't a need to copy this information anymore. The purpose was to copy it for each isolate, but that is no longer necessary. removing
|
OK, so I went ahead and added inquirer directly to this repo since that was causing issues as well |
|
👍 |
Applications can now be stopped (this is good for tests), and they can wait for stop to finish.
Updated Application to use new Dart 1.13 API for starting HTTPS sever.
Privatized HttpController's response type/encoder and added a public-only method for setting both at the same time.
Code cleanup, test updates.