This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should remove the context from the ResourceRequest entirely and just create a ResourceRequest subclass that contains the adapter, permissions, and auth server for Wildfire. I never liked the idea of passing around arbitrary objects in a dictionary. |
@@ -2,8 +2,11 @@ | |||
<project version="4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add the workspace.xml to the .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rosshambrick @JesseBlack82 @anachlas
Made Application class generic. This means that instead of
The following is now the appropriate way (once merged)
Where Pipeline is the app specific Pipeline, and Request is either REsourceRequest or possibly an app specific ResourceRequest. The purpose of providing ResourceRequest here is that you can now provide another class to provide options on the REsourceREquest. Right now, options are provided by adding key-value pairs to the context property of the ResourceRequest; e.g., the PostgresqlModelAdapter.
We should now be able to supply this as a property.
Then, in your pipeline, you can set these values a lot more intuitively:
Submitted as PR for review and to avoid conflicts on your current projects