From 57ded6b1c5758c97ddf4dd5e12d48d0c2ad5ba15 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Wed, 27 Mar 2024 18:24:43 +0100 Subject: [PATCH 01/25] GH Actions: run tests also on Windows OS When running the tests locally, I realized that patch 146 did not actually work correctly on Windows. This commit adds test runs against Windows in CI on a limited number of PHP versions to prevent this kind of issue going unnoticed for future PRs. Note: the lowest PHP version I can get a running build on is PHP 5.5. This is related to SSL transport issues with Packagist with old Composer versions (which are needed for old PHP versions). --- .github/workflows/test.yml | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 24a750b..8b69d3f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -91,8 +91,8 @@ jobs: path: ./parallel-lint.phar test: - name: Run tests on PHP ${{ matrix.php }} - runs-on: ubuntu-latest + name: Run tests on PHP ${{ matrix.php }} (${{ matrix.os }}) + runs-on: "${{ matrix.os }}" continue-on-error: ${{ matrix.php == '8.4' }} needs: - bundle @@ -114,6 +114,19 @@ jobs: - '8.2' - '8.3' - '8.4' + os: + - 'ubuntu-latest' + + include: + # Also run the tests against Windows on a few PHP versions. + - php: '5.5' + os: 'windows-latest' + - php: '7.0' + os: 'windows-latest' + - php: '8.0' + os: 'windows-latest' + - php: '8.3' + os: 'windows-latest' steps: - name: Checkout code From 8becf5742e14536ee6e8b109475dbf6f562d2bf4 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Wed, 2 Oct 2024 13:34:36 +0200 Subject: [PATCH 02/25] GH Actions: tweak to get commands running on Windows --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8b69d3f..5c747f8 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -167,7 +167,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version - run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + run: echo "VERSION=$(php "vendor/bin/phpunit" --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} @@ -182,4 +182,4 @@ jobs: name: parallel-lint-phar - name: Run linter against codebase using the phar - run: php ./parallel-lint.phar --exclude vendor --exclude tests/fixtures . + run: php "parallel-lint.phar" --exclude vendor --exclude tests/fixtures . From 2321f6fa8fb0d8126dbd8a28495a4201636c9cd0 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 13:48:49 +0200 Subject: [PATCH 03/25] debug --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5c747f8..12ceeb6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -165,9 +165,9 @@ jobs: - name: 'Integration test 2 - linting own code' run: ./parallel-lint --exclude vendor --exclude tests/fixtures . - - name: Grab PHPUnit version - id: phpunit_version - run: echo "VERSION=$(php "vendor/bin/phpunit" --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + - run: echo php "vendor/bin/phpunit" --version + - run: grep --help + - run: echo "PHPUnit 10.5.35 " | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} From 0a6df23b8eef4a902c5b207fc02b49a86831480f Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 13:53:09 +0200 Subject: [PATCH 04/25] Update test.yml --- .github/workflows/test.yml | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 12ceeb6..38ccda7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -99,24 +99,6 @@ jobs: strategy: matrix: - php: - - '5.3' - - '5.4' - - '5.5' - - '5.6' - - '7.0' - - '7.1' - - '7.2' - - '7.3' - - '7.4' - - '8.0' - - '8.1' - - '8.2' - - '8.3' - - '8.4' - os: - - 'ubuntu-latest' - include: # Also run the tests against Windows on a few PHP versions. - php: '5.5' From 28a9285872e6c6b7db8516f9fe850791f236514e Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 13:59:08 +0200 Subject: [PATCH 05/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 38ccda7..1408097 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -149,7 +149,7 @@ jobs: - run: echo php "vendor/bin/phpunit" --version - run: grep --help - - run: echo "PHPUnit 10.5.35 " | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} From c98a32180fdbc4870d98f0693cba01c31ac351c6 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 13:59:48 +0200 Subject: [PATCH 06/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1408097..8c441ba 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -149,7 +149,7 @@ jobs: - run: echo php "vendor/bin/phpunit" --version - run: grep --help - - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+'" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} From 268d49e1bd26552751721ae9568c288bfd739556 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:00:09 +0200 Subject: [PATCH 07/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8c441ba..9a91e67 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -147,7 +147,7 @@ jobs: - name: 'Integration test 2 - linting own code' run: ./parallel-lint --exclude vendor --exclude tests/fixtures . - - run: echo php "vendor/bin/phpunit" --version + - run: echo php vendor/bin/phpunit --version - run: grep --help - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+'" >> $GITHUB_OUTPUT From 36de07907a041dde7fa415fe513e7181a7058aee Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:00:21 +0200 Subject: [PATCH 08/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9a91e67..0114919 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -147,7 +147,7 @@ jobs: - name: 'Integration test 2 - linting own code' run: ./parallel-lint --exclude vendor --exclude tests/fixtures . - - run: echo php vendor/bin/phpunit --version + - run: php vendor/bin/phpunit --version - run: grep --help - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+'" >> $GITHUB_OUTPUT From e8dbb0151c6ccc75be6b12403412c01714cf376e Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:02:35 +0200 Subject: [PATCH 09/25] Update test.yml --- .github/workflows/test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0114919..f8d5525 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -149,7 +149,8 @@ jobs: - run: php vendor/bin/phpunit --version - run: grep --help - - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+'" >> $GITHUB_OUTPUT + - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+' >> $GITHUB_OUTPUT + id: phpunit_version - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} From fbf4d8363208094da998ab50096b603d0b4e26b4 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:05:25 +0200 Subject: [PATCH 10/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f8d5525..60e6148 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -149,7 +149,7 @@ jobs: - run: php vendor/bin/phpunit --version - run: grep --help - - run: echo "PHPUnit 10.5.35 " | egrep --only-matching --max-count=1 '\b[0-9]+\.[0-9]+' >> $GITHUB_OUTPUT + - run: echo "PHPUnit 10.5.35 " | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+' >> $GITHUB_OUTPUT id: phpunit_version - name: "Run unit tests (PHPUnit < 10)" From 0c39cdb534c27ccd66fb9d84450261e54e101427 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:08:07 +0200 Subject: [PATCH 11/25] Update test.yml --- .github/workflows/test.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 60e6148..3f9c4d6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -149,9 +149,12 @@ jobs: - run: php vendor/bin/phpunit --version - run: grep --help - - run: echo "PHPUnit 10.5.35 " | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+' >> $GITHUB_OUTPUT +# - run: echo "PHPUnit 10.5.35 " | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+' >> $GITHUB_OUTPUT + # id: phpunit_version + - name: Grab PHPUnit version id: phpunit_version - + run: echo "VERSION=$(php vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + - - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} run: composer test From be8019021397124ce475ef2a0320892476ab1462 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:09:31 +0200 Subject: [PATCH 12/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3f9c4d6..de2db54 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -154,7 +154,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version run: echo "VERSION=$(php vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - - + - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} run: composer test From da47b37bebf678244e00ca320632391355eb84d3 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:30:20 +0200 Subject: [PATCH 13/25] Update test.yml --- .github/workflows/test.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index de2db54..7453033 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -147,13 +147,11 @@ jobs: - name: 'Integration test 2 - linting own code' run: ./parallel-lint --exclude vendor --exclude tests/fixtures . - - run: php vendor/bin/phpunit --version - - run: grep --help -# - run: echo "PHPUnit 10.5.35 " | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+' >> $GITHUB_OUTPUT - # id: phpunit_version - name: Grab PHPUnit version id: phpunit_version - run: echo "VERSION=$(php vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + run: | + VER_STR=$(vendor/bin/phpunit --version) + echo "VERSION=$(echo $VER_STR | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} From ac537f2a64e138b970853d12d48214e980c4aa81 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:32:43 +0200 Subject: [PATCH 14/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7453033..d122f17 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -150,7 +150,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version run: | - VER_STR=$(vendor/bin/phpunit --version) + VER_STR=$(php vendor/bin/phpunit --version) echo "VERSION=$(echo $VER_STR | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" From 51ea7203ef41cf10e092c6322caa89db14be4043 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:34:39 +0200 Subject: [PATCH 15/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d122f17..f8db20e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -150,7 +150,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version run: | - VER_STR=$(php vendor/bin/phpunit --version) + VER_STR=$(php 'vendor/bin/phpunit' --version) echo "VERSION=$(echo $VER_STR | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" From bf453eab287290435599068d6a2a5283bd825240 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:45:07 +0200 Subject: [PATCH 16/25] Update test.yml --- .github/workflows/test.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f8db20e..a216267 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -150,15 +150,14 @@ jobs: - name: Grab PHPUnit version id: phpunit_version run: | - VER_STR=$(php 'vendor/bin/phpunit' --version) - echo "VERSION=$(echo $VER_STR | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + echo "VERSION=$(php 'vendor/bin/phpunit' --version)" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" - if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} + if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} run: composer test - name: "Run unit tests (PHPUnit < 10)" - if: ${{ startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} + if: ${{ startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} run: composer test10 - uses: actions/download-artifact@v4 From 3a792db90e4e8cb98547228c8ea9378ff3003caf Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:45:49 +0200 Subject: [PATCH 17/25] Update test.yml --- .github/workflows/test.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a216267..5ad93b2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -149,8 +149,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version - run: | - echo "VERSION=$(php 'vendor/bin/phpunit' --version)" >> $GITHUB_OUTPUT + run: echo "VERSION=$(php 'vendor/bin/phpunit' --version)" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} From e3ee02a672d4506dfd91be2dd821db42ef98c794 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:51:20 +0200 Subject: [PATCH 18/25] Update test.yml --- .github/workflows/test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5ad93b2..24b8219 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -149,7 +149,8 @@ jobs: - name: Grab PHPUnit version id: phpunit_version - run: echo "VERSION=$(php 'vendor/bin/phpunit' --version)" >> $GITHUB_OUTPUT + shell: bash + run: echo "VERSION=$(php vendor/bin/phpunit --version)" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} From 959a4b19f87bc62987c6fef82624014c092c0e76 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 14:53:28 +0200 Subject: [PATCH 19/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 24b8219..eb5dc6d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -150,7 +150,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version shell: bash - run: echo "VERSION=$(php vendor/bin/phpunit --version)" >> $GITHUB_OUTPUT + run: echo "VERSION=$(echo vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} From 8d6d2fbc65624bd679cd1f2bf6c986cfda529291 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 15:08:09 +0200 Subject: [PATCH 20/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index eb5dc6d..1eb99eb 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -150,7 +150,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version shell: bash - run: echo "VERSION=$(echo vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + run: echo "VERSION=$(php vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} From c8418b8bad3a4cef4d02d43cfdce6c748ad28933 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 15:09:16 +0200 Subject: [PATCH 21/25] Update test.yml --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1eb99eb..4ffc767 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -153,11 +153,11 @@ jobs: run: echo "VERSION=$(php vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" - if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} + if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} run: composer test - name: "Run unit tests (PHPUnit < 10)" - if: ${{ startsWith( steps.phpunit_version.outputs.VERSION, 'PHPUnit 10.' ) }} + if: ${{ startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} run: composer test10 - uses: actions/download-artifact@v4 From dceedd6fddeb47a2cd6b535d7cf6d9f2a0f47351 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 15:13:07 +0200 Subject: [PATCH 22/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4ffc767..e0bd7f3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -150,7 +150,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version shell: bash - run: echo "VERSION=$(php vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + run: echo "VERSION=$(echo vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} From 04aff64f10e712fcc87cd9d6d18007d26e41cd0c Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 15:13:57 +0200 Subject: [PATCH 23/25] Update test.yml --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e0bd7f3..b0b83e4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -152,6 +152,8 @@ jobs: shell: bash run: echo "VERSION=$(echo vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + - run: ${{steps.phpunit_version.outputs.VERSION}} + - name: "Run unit tests (PHPUnit < 10)" if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }} run: composer test From 8f708677f194db10bcbbf7692f13f30f7de62ae8 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 15:14:10 +0200 Subject: [PATCH 24/25] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b0b83e4..875261a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -150,7 +150,7 @@ jobs: - name: Grab PHPUnit version id: phpunit_version shell: bash - run: echo "VERSION=$(echo vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT + run: echo "VERSION=$(php vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT - run: ${{steps.phpunit_version.outputs.VERSION}} From ce545ad1f8cb50047fb3049d24bb91aa4c72ba49 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Wed, 2 Oct 2024 15:14:46 +0200 Subject: [PATCH 25/25] Update test.yml --- .github/workflows/test.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 875261a..7ddd28f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -101,10 +101,6 @@ jobs: matrix: include: # Also run the tests against Windows on a few PHP versions. - - php: '5.5' - os: 'windows-latest' - - php: '7.0' - os: 'windows-latest' - php: '8.0' os: 'windows-latest' - php: '8.3'