#23 - Overhaul OrderManager.completeOrder() #103
Conversation
savety. Add first test.
savety. Add first test.
Fixed small typo.
savety. Add first test.
#23 Conflicts: src/main/java/org/salespointframework/order/PersistentOrderManager.java src/test/java/org/salespointframework/order/OrderManagerTests.java
|
Any chance you avoid all formatting related changes? It's rally hard to see what has really changed. |
|
good question, tried to rebase to master. But looks like that this is the diff of both branches. |
|
Well, I am not really in charge of changing what's in this PR and I don't have the time to dive into the changes and find out what actually has been changed. So I guess we need to get to a PR that is reduced to only the intended changes. From a quick glance it looks like your formatting changes replace tabbed indentation with spaces. Please make sure you use the Eclipse formatter defined in |
|
Can we actually close this one? |
|
Yes, the actual one is too dirty with other commits. |
Overhaul OrderManager.completeOrder(), now completeOrder() returns new Object containing status and list of elements due to the status.
Returning OrderCompletionResult with status FAILED_PRODUCTS_UNDERSTOCKED returns the list of products, that are understocked, other status same way.