Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't process QBFT messages after instance is decided #473

Closed
Tracked by #479
GalRogozinski opened this issue Aug 7, 2024 · 2 comments
Closed
Tracked by #479

Don't process QBFT messages after instance is decided #473

GalRogozinski opened this issue Aug 7, 2024 · 2 comments
Labels
bug Something isn't working consensus consensus related issues

Comments

@GalRogozinski
Copy link
Contributor

GalRogozinski commented Aug 7, 2024

Description

Even after an instance is decided we process messages. This is in order to gather more commit messages for Explorer usage.
It is unclear why spec should be concerned with explorer. Allowing to process messages after decided can lead to sudden unexpected behaviors like creating extra round changes.

@GalRogozinski GalRogozinski added bug Something isn't working consensus consensus related issues labels Aug 7, 2024
@olegshmuelov
Copy link
Contributor

olegshmuelov commented Aug 14, 2024

Just to clarify, the exporter is now operating differently, and we no longer need to gather additional commit messages after an instance is decided. This change was implemented with the merging of PR #1409 into the stage branch.

Additionally, as a reminder, it's still necessary to process post-consensus messages after an instance has been decided.

@GalRogozinski
Copy link
Contributor Author

@olegshmuelov
of course I am only talking about QBFT messages the instance processes

@olegshmuelov olegshmuelov changed the title Don't process messages after instance is decided Don't process QBFT messages after instance is decided Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working consensus consensus related issues
Projects
None yet
Development

No branches or pull requests

3 participants