Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include licenses for Rust standard library #24

Open
jwodder opened this issue Oct 27, 2023 · 2 comments
Open

Include licenses for Rust standard library #24

jwodder opened this issue Oct 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jwodder
Copy link
Contributor

jwodder commented Oct 27, 2023

Third-party crates aren't a Rust program's only dependencies; compiled Rust binaries also link with the std or core crate, both of which are dual-licensed under MIT and Apache 2.0, and thus their licenses need to be bundled as well. See rust-lang/rust#67014 for more information.

@sstadick sstadick added the enhancement New feature or request label Oct 30, 2023
@sstadick
Copy link
Owner

Great point that I wouldn't have considered. That's not too hard to always add a core license I suppose, but we'd need to detect if something is no-std, which seems trickier? Leaving this as an open enhancement for now.

@BatmanAoD
Copy link

As a stop-gap, could the tool just manually copy over any top-level entries in the --previous file that it doesn't recognize (i.e. anything other than root_name and third_party_libraries)? This would allow users to manually add something like:

rust:
- package_name: std
  package_version: 1.82.0
  repository: https://github.com/rust-lang/rust
  license: MIT OR Apache-2.0
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants