Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review suggestions #3

Open
3 tasks
tsevdos opened this issue Mar 10, 2023 · 0 comments
Open
3 tasks

Code review suggestions #3

tsevdos opened this issue Mar 10, 2023 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@tsevdos
Copy link

tsevdos commented Mar 10, 2023

All the features are working fine and the structure / code of the project is really good! I also love tailwind by the way...

Suggestions for implementation:

  • Fix all linting errors (easy)
  • Clear the "Add new course" form after successfully add a new course (easy)
  • Check if you can combine the functionality of the "Edit Course" component with the "Add New Course" component. You can use the same form, in the first case the "initial values" will be your current course data, and in the second one it will be the same data (abject) with empty values (hard)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

5 participants