You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've found a bit confusing the fact that at master branch in triangle(..) there is bc_clip argument which is assuming we have already performed clipping. But the course Wiki says it is projection that helps us to clip vertices. And in the code we see Projection applied to bc_clip (already clipped?) vertices. Maybe I miss something..
But I think it may be useful to note that if we know parameter r=1/D where D is screen-plane-to-camera distance and planes Z=0, Z=farthest_distance, we can clip vertices before applying Projection matrix and that will bring meaning to bc_clip argument name.
What do you think?
The text was updated successfully, but these errors were encountered:
I've found a bit confusing the fact that at master branch in
triangle(..)
there isbc_clip
argument which is assuming we have already performed clipping. But the course Wiki says it is projection that helps us to clip vertices. And in the code we see Projection applied tobc_clip
(already clipped?) vertices. Maybe I miss something..But I think it may be useful to note that if we know parameter
r=1/D
whereD
is screen-plane-to-camera distance and planes Z=0, Z=farthest_distance, we can clip vertices before applying Projection matrix and that will bring meaning tobc_clip
argument name.What do you think?
The text was updated successfully, but these errors were encountered: