Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check duplicate sample in a ServiceXSpec #499

Closed
kyungeonchoi opened this issue Oct 15, 2024 · 0 comments · Fixed by #501
Closed

Check duplicate sample in a ServiceXSpec #499

kyungeonchoi opened this issue Oct 15, 2024 · 0 comments · Fixed by #501

Comments

@kyungeonchoi
Copy link
Contributor

Story

A ServiceXSpec can have multiple Samples. The current version of client (v3.0.0) allows a user to have multiple samples with the identical dataset and query in a ServiceXSpec. It happily runs both requests (although the same query on the same dataset) and downloads both at different data directories. Only first request is cached.

Acceptance Criteria

ServiceX client should throw an error when there are samples with the identical dataset and query prior to submit to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant