Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG 11 Fix #18

Open
Yo71MUd2gEu5 opened this issue Jun 19, 2019 · 5 comments
Open

PG 11 Fix #18

Yo71MUd2gEu5 opened this issue Jun 19, 2019 · 5 comments

Comments

@Yo71MUd2gEu5
Copy link

Yo71MUd2gEu5 commented Jun 19, 2019

Seems that PG 11 is not supported fully.

PostgreSQL server info:
Version : 11.3
Release : 1PGDG.rhel7
From repo : pgdg11

Slony info:
Version : 2.2.7
Release : 2.rhel7
From repo : pgdg11

When trying to initialize master i've got a message:

slonik <<EOF

CLUSTER NAME = CLUSTER;
NODE 1 ADMIN CONNINFO = 'dbname=SL_MASTER user=slonik';
INIT CLUSTER ( ID = 1, COMMENT = 'Asterisk DB replication cluster' );

EOF

initialzing cluster
:4: Possible unsupported PostgreSQL version (110300) 11.3, defaulting to 8.4 support

@ssinger
Copy link
Owner

ssinger commented Jun 21, 2019

It actually does work against PG 11, the warning can be ignored. The last version of slony was released while PG 11 was still beta(I think)
In the next release I will remove the warning for PG11.

@tim-rex
Copy link

tim-rex commented Nov 2, 2022

It appears this is still the case for all postgres versions above PG13

I only mention this since slony 2.2.11 just landed, and the release notes indicate support for PG15

slonik.c

else	/* above 13 */
	{
		use_major = 8;
		use_minor = 4;
		printf("%s:%d: Possible unsupported PostgreSQL "
			   "version (%d) %d.%d, defaulting to support for latest\n",
			   stmt->stmt_filename, stmt->stmt_lno, adminfo->pg_version,
		(adminfo->pg_version / 10000), ((adminfo->pg_version % 10000) / 100));
	}

@ssinger
Copy link
Owner

ssinger commented Nov 2, 2022

This should be fixed in 2.2.11
https://github.com/ssinger/slony1-engine/blob/REL_2_2_STABLE/src/slonik/slonik.c

(though I was a bit late in pushing 2.2.11 to this github repo (The official repo is at git.postgresql.org)

@tim-rex
Copy link

tim-rex commented Nov 2, 2022

Ahh, so I see. Thanks.

It looks like load_slony_base() is setup correctly, though load_slony_functions() still considers PG15 as "possibly unsupported"

@ssinger
Copy link
Owner

ssinger commented Nov 3, 2022

I've pushed a fix for this to REL_2_2_STABLE.
I'm hesitant to cut a 2.2.12 release just to remove the warning(but could be convinced otherwise)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants