Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remove-signup): find document by props instead of discordId #512

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ssilve1989
Copy link
Owner

@ssilve1989 ssilve1989 commented Oct 17, 2024

Resolves #509

@ssilve1989 ssilve1989 merged commit 4a19268 into master Oct 17, 2024
5 checks passed
@ssilve1989 ssilve1989 deleted the issue/509 branch October 17, 2024 02:46
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (93ad9d4) to head (800d3db).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/firebase/collections/signup.collection.ts 0.00% 7 Missing ⚠️
src/signup/signup.service.ts 0.00% 5 Missing ⚠️
src/types/global.d.ts 0.00% 2 Missing ⚠️
src/sheets/sheets.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   61.69%   61.56%   -0.14%     
==========================================
  Files         128      129       +1     
  Lines        5412     5422      +10     
  Branches      437      438       +1     
==========================================
- Hits         3339     3338       -1     
- Misses       2073     2084      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ssilve1989 added a commit that referenced this pull request Oct 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.17.2](v1.17.1...v1.17.2)
(2024-10-17)


### Bug Fixes

* **remove-signup:** find document by props instead of discordId
([#512](#512))
([4a19268](4a19268)),
closes [#509](#509)
* **remove-signup:** handle UPDATE_PENDING as valid status for sheet
removal ([#510](#510))
([93ad9d4](93ad9d4)),
closes [#508](#508)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Remove Signup doesn't remove Firestore entry in all cases
1 participant