Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signups): clear-checker cron #497

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat(signups): clear-checker cron #497

merged 1 commit into from
Nov 11, 2024

Conversation

ssilve1989
Copy link
Owner

@ssilve1989 ssilve1989 commented Oct 7, 2024

Create a cron-task that checks the list to clean up entries that have cleared but not yet reported that they have. Uses the FFLogs API to check that.

Can be used in two modes:

  • report: this mode will just report its findings and do nothing
  • execute: this mode will remove entries it found and report the results

@ssilve1989 ssilve1989 changed the title wip: codegen fflogs api feat(signups): clear-checker cron Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 37.18141% with 419 lines in your changes missing coverage. Please review.

Project coverage is 59.64%. Comparing base (1e6dc14) to head (595788b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/fflogs/graphql/sdk.ts 0.30% 331 Missing ⚠️
src/fflogs/fflogs.service.ts 9.09% 30 Missing ⚠️
src/fflogs/fflogs.module.ts 0.00% 22 Missing ⚠️
src/tasks/clear-checker/clear-checker.job.ts 88.51% 17 Missing ⚠️
src/tasks/clear-checker/clear-checker.module.ts 0.00% 10 Missing ⚠️
src/fflogs/queries.ts 0.00% 5 Missing ⚠️
src/app.config.ts 0.00% 1 Missing ⚠️
src/app.module.ts 0.00% 1 Missing ⚠️
src/fflogs/fflogs.interfaces.ts 50.00% 1 Missing ⚠️
...rc/tasks/clear-checker/clear-checker.interfaces.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   62.35%   59.64%   -2.71%     
==========================================
  Files         132      145      +13     
  Lines        5541     6208     +667     
  Branches      460      498      +38     
==========================================
+ Hits         3455     3703     +248     
- Misses       2086     2505     +419     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssilve1989 ssilve1989 merged commit 4814608 into master Nov 11, 2024
8 checks passed
@ssilve1989 ssilve1989 deleted the feat/fflogs-module branch November 11, 2024 20:23
ssilve1989 added a commit that referenced this pull request Nov 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.20.0](v1.19.0...v1.20.0)
(2024-11-11)


### Features

* **signups:** Creates a new daily job that uses FFLogs to check if
people have signed up have now cleared and should be removed
([#497](#497))
([4814608](4814608))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
ssilve1989 added a commit that referenced this pull request Nov 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.20.0](v1.19.0...v1.20.0)
(2024-11-11)


### Features

- **signups:** Creates a new daily job that uses FFLogs to check if
people have signed up have now cleared and should be removed
([#497](#497))
([4814608](4814608))
- This feature comes in two modes. The first mode will be an
experimental reporting mode where it will take no action, and just
report the results.

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant