Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When is a version with async support going to be released to NuGet? #1040

Closed
IanKemp opened this issue Nov 10, 2022 · 13 comments
Closed

When is a version with async support going to be released to NuGet? #1040

IanKemp opened this issue Nov 10, 2022 · 13 comments

Comments

@IanKemp
Copy link

IanKemp commented Nov 10, 2022

TAP code has been in the develop branch for nearly a year and the last actual feature release was nearly 2 years ago... all of the open issues in the vNext milestone are old and the linked PRs that some of them have, have been waiting since March... I appreciate that this project may not be a priority due to time pressures, but publishing a version with TAP support would go a long way towards easing the use of this library.

@drieseng
Copy link
Member

I'm really sorry about the lack of activity. I'm gonna try to get more people involved soon, and will try to free more time for this project myself.

@dca00
Copy link

dca00 commented Nov 11, 2022

The existing works perfectly fine when wrapped in a Task: a 2-liner. Awaiting would be nice but not a real change in function.

@IanKemp
Copy link
Author

IanKemp commented Nov 14, 2022

I'm really sorry about the lack of activity. I'm gonna try to get more people involved soon, and will try to free more time for this project myself.

I understand completely, and it's good to know you haven't abandoned the project!

The existing works perfectly fine when wrapped in a Task: a 2-liner. Awaiting would be nice but not a real change in function.

The whole point of a library is so I don't have to write that sort of code.

@dca00
Copy link

dca00 commented Nov 17, 2022

The whole point of a library is so I don't have to write that sort of code.

In ideal world, all code will be written for us by someone else. In less than ideal world, we have to write it. When the effort is so minimal it is not reasonable to demand it, while there are more serious issues with the library than this. A long list of issues to go through exists, and I had to write tons more boilerplate code, to work around some of them, than this.

@wertzui
Copy link

wertzui commented Nov 18, 2022

@dca00 wrapping a sync method in Task.Run wil actually use a Thread instead of being really asynchronous.
To be rally asynchronous you have to use Task all the way down to the IO level which will then result not in a Thread, but in an hardware interrupt.
For SSH.NET this means using the ...Async methods of the underlying Socket which is what you can see in the current async branch.

@dca00
Copy link

dca00 commented Nov 18, 2022

Which is only important if you are a hacker who hacks into thousands if not tens of thousands of victim hosts at the same time.

@darkoperator
Copy link

darkoperator commented Nov 18, 2022 via email

@dca00
Copy link

dca00 commented Nov 18, 2022

If this is what you want to prioritize, power to you! I've walked away a long time ago.

@IanKemp
Copy link
Author

IanKemp commented Nov 18, 2022

Which is only important if you are a hacker who hacks into thousands if not tens of thousands of victim hosts at the same time.

This is the most ridiculous non-argument I've ever heard against releasing a feature that makes code simpler and more performant. Especially when said feature is already written.

@darkoperator
Copy link

darkoperator commented Nov 18, 2022 via email

@wertzui
Copy link

wertzui commented Nov 19, 2022

Which is only important if you are a hacker who hacks into thousands if not tens of thousands of victim hosts at the same time.

Which is the difference between a reasonable software developer and a script kiddy.

@superware
Copy link

Thank you for the great work! When is a version with async support going to be released to NuGet?

@SuperJMN
Copy link

SuperJMN commented Aug 2, 2023

I'm eagerly waiting for async version, too. Thanks for the good work you're doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants