Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IDisposable to ISftpClient, as well as Connect and Disconnect #1019

Closed
fjmorel opened this issue Oct 21, 2022 · 2 comments
Closed

Add IDisposable to ISftpClient, as well as Connect and Disconnect #1019

fjmorel opened this issue Oct 21, 2022 · 2 comments

Comments

@fjmorel
Copy link

fjmorel commented Oct 21, 2022

SftpClient implements IDisposable, but ISftpClient doesn't. So I can't dispose of clients if I pass one around by interface.

The same thing applies to the Connect and Disconnect methods as well.
@S-Jindal
Copy link

@fjmorel would you take that up? If possible, please open a PR for this.

I think there are too many open issues which are quite trivial to address and seems like the primary author of this project @drieseng is not taking up fixes actively.

@JonAnders
Copy link

I believe this was fixed in #975, but not released yet.

@fjmorel fjmorel closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JonAnders @fjmorel @S-Jindal