Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin chain issue #181

Closed
sshivaditya2019 opened this issue Oct 18, 2024 · 2 comments
Closed

Plugin chain issue #181

sshivaditya2019 opened this issue Oct 18, 2024 · 2 comments

Comments

@sshivaditya2019
Copy link
Owner

sshivaditya2019 commented Oct 18, 2024

right now it's messy that every plugin posts their own comments. It allows for flexibility but I think it's a bad idea for it to be the main way.

I propose we have a method that lets the developer pass in the comments data and the kernel posts the comment on the behalf of the plugin.

Great example of a plugin comment that should be inside of the /start message.

I envision it can just append this below the /start table basically.

Make it so plugins can append if ran in a chain. This was discussed before by leveraging KV run ID in the metadata and such.

Originally posted by @ubiquity-os-betas in ubiquity-os-marketplace/text-conversation-rewards#113 (comment)

Repository owner deleted a comment from test-app-ubo bot Nov 18, 2024
Repository owner deleted a comment from test-app-ubo bot Nov 18, 2024
@test-app-ubo test-app-ubo bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@sshivaditya2019
Copy link
Owner Author

@ubosshivaditya can you explain the linked issues ?

@test-app-ubo
Copy link

test-app-ubo bot commented Nov 18, 2024

Certainly! The linked issues focus on improving how plugin-generated comments are managed within your repository to enhance clarity and maintainability. Here's a summary of each:

  1. Consolidate comments (#210)
    This issue addresses the clutter caused by multiple plugins posting individual comments. The proposed solution is to consolidate these comments into a single, managed comment, reducing noise and improving readability.

  2. Consolidated Comment Per Plugin Chain Run ID (#178)
    Here, the discussion revolves around using unique run IDs from Cloudflare KV to organize comments generated by each plugin. This method ensures that comments are grouped appropriately, making it easier to track and manage plugin interactions.

  3. Consolidated Comment Per Plugin Chain Run ID (#180)
    Similar to issue Consolidated Comment Per Plugin Chain Run ID  #178, this task emphasizes appending comments within plugin chains using metadata like plugin IDs. The goal is to allow plugins to add their sections without interfering with each other, maintaining a structured comment format.

  4. Consolidated Comment Per Plugin Chain Run ID (#179)
    This issue further explores the implementation details of consolidating plugin comments. It discusses parsing section separators with regex to identify and manage each plugin's output effectively.

Common Theme Across Issues:
All these issues aim to streamline the process of handling comments from multiple plugins by centralizing them under a unified structure. By doing so, it enhances the scalability of the system, ensures type safety, and maintains a clean and organized comment history within issues and pull requests.

If you have any specific questions about these issues or need further clarification on their implementations, feel free to ask!

@test-app-ubo test-app-ubo bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant