Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbot@13 bin.js has no support for websockets at all #554

Closed
regular opened this issue Oct 14, 2018 · 6 comments
Closed

sbot@13 bin.js has no support for websockets at all #554

regular opened this issue Oct 14, 2018 · 6 comments
Labels

Comments

@regular
Copy link
Contributor

regular commented Oct 14, 2018

  • ws.getAddress now is an unknown command (bad, breaks backward compatibility)
  • getAddress returns no ws address either.

Currently there is no way to connect to a stock sbot from a browser.

@regular
Copy link
Contributor Author

regular commented Oct 14, 2018

To reproduce:

git clone https://github.com/regular/ssb-integration-tests.git
cd ssb-integration-tests
npm i
npm t

@christianbundy
Copy link
Contributor

Can confirm, although I'm not familiar enough with the plugin logic to understand why this is happening. It seems like this may be related to #551, but I'm not sure what the fix might be.

@regular
Copy link
Contributor Author

regular commented Oct 15, 2018

it's because the ws plugin's create function is only called when there is config.connections.incoming.ws, which is not the case by default (but it should, because sbot used to support ws out of the box before the connection refactor) This is fixed in ssbc/ssb-config#22

@regular
Copy link
Contributor Author

regular commented Oct 20, 2018

fixed in ssb-config 2.3.6

@christianbundy
Copy link
Contributor

Sweet, since this repo installs ssb-config@^2.3.0 does that mean this issue is ready to close?

@regular
Copy link
Contributor Author

regular commented Oct 23, 2018

Yes, I think so

@regular regular closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants