Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid referencing latest in Dockerfile #95

Closed
georgespalding opened this issue Oct 10, 2023 · 2 comments · Fixed by #96
Closed

Avoid referencing latest in Dockerfile #95

georgespalding opened this issue Oct 10, 2023 · 2 comments · Fixed by #96
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@georgespalding
Copy link

The Dockerfile used to fetch the binary used for the action references latest in all recent versions.

ARG ASSET_URL=https://github.com/srvaroa/labeler/releases/latest/download/action.tar.gz

This is not great because it put the labeler action out of commision for all releases of the action, when the 1.6.2 release failed to create the action.tar.gz file in "latest" downloads location.

@srvaroa
Copy link
Owner

srvaroa commented Oct 10, 2023

Yeah I agree with this. It's a leftover from when the action binary was compiled upon run and I kept it to avoid complicating the release process, but at this point it's safer to go that way.

I'll get this fixed soon.

Thanks!

@srvaroa srvaroa added enhancement New feature or request good first issue Good for newcomers labels Oct 10, 2023
@srvaroa
Copy link
Owner

srvaroa commented Oct 10, 2023

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants