-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-text search query #102
Comments
Not having full-text search (including client-side search) is a dealbreaker for some projects, eg: hercules-ci/flake-parts#31 (comment) |
Adding stork, as suggested in #242 (comment), was surprisingly easy. Made a proof-of-concept just to play around, and it works super well :) Client-side of this is easy. The hard part of course it to get Haskell to talk the same language and make use of the search results during Porting Stork to Haskell isn't realistic. However their CLI seems capable enough. Stork always rebuild the index from scratch, which is bad for bigger sites. However just to get a perspective, here's some quick benchmarks:
The index-building times are really good, even for the bigger repos. And if you lock in to the idea of using Stork, then adding at least statically-built search results is a great start, and would deserve a separate ticket. My idea of how search support would be added to Emanote:
Sending pages to Stork during Other ideas:
These are just my two cents. What are your thoughts, @srid ? Maybe this was your plan all along? |
I agree, and this is what we should do first (without worrying about the
Could you share how you did this? I imagine we can make By the way, the which library can be used to include |
Separate ticket opened: #324 Let's continue the discussion there. |
Yea sure: |
We have client-side full text search now, but to integrate it with the query feature we will need #338 |
Using Using FFI could improve performance as it would skip translating back and forth between JSON, so suggest keeping it as a possible future enhancement. But the low-hanging fruit is just to use the CLI as you are when building the index. |
Now that we have #324, enable access to it from the query feature. The following,
... should list all notes containing 'some text'. Inspired by Obsidian.
See #48 (reply in thread)
We could piggyback on #338 to implement this.
The text was updated successfully, but these errors were encountered: