Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitty autocomplete color is unreadably dark #14

Closed
peschkaj opened this issue May 30, 2019 · 11 comments
Closed

kitty autocomplete color is unreadably dark #14

peschkaj opened this issue May 30, 2019 · 11 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@peschkaj
Copy link

The autocomplete color in kitty is all but unreadable, even at very high brightness on my displays. Something with higher contrast would be beneficial for all users of Kitty.

Which color is this in the general kitty color scheme?

Selection-2019-05-30-002

@roosta
Copy link
Member

roosta commented May 30, 2019

Yeah, I've noticed the same issue with comments in terminal. It uses bright black as the color, I don't know how to fix this save for changing the bright-black color to something lighter, more in line with how white looks now. In vim it uses white as the comment color.

It looks like srcery needs a few palette tweaks, I'll try to make some updates over the weekend, stay tuned.

@peschkaj
Copy link
Author

For what it's worth, I found #807d74 to be an acceptable color for bright-black. There's probably a better choice that fits in more with the theme, but it does work for the moment.

@roosta
Copy link
Member

roosta commented Jun 3, 2019

Sorry about the delay on this, I'll get around to it soon. Been busy. Glad you found something that works temporarily.

@MindTooth
Copy link
Member

I’ll take a look tomorrow. But I’ve not noticed this to be an issue yet, or at least not been put off by it.

@MindTooth MindTooth self-assigned this Sep 23, 2019
@MindTooth MindTooth added bug Something isn't working enhancement New feature or request labels Sep 23, 2019
@MindTooth
Copy link
Member

What shell are you using?

Changing color8 resulted in changes in more than one place, and that is not suitable.

@peschkaj
Copy link
Author

I'm using ZSH with purepower (which itself uses powerlevel10k). My current color config from kitty is:

# Main Colors {{{

# Black
color0               #1C1B19
color8               #807d74

# Red
color1               #EF2F27
color9               #F75341

# Green
color2               #519F50
color10              #98BC37

# Yellow
color3               #FBB829
color11              #FED06E

# Blue
color4               #2C78BF
color12              #68A8E4

# Magenta
color5               #E02C6D
color13              #FF5C8F

# Cyan
color6               #0AAEB3
color14              #53FDE9

# White
color7               #918175
color15              #FCE8C3

# }}}

In the effort of helping you duplicate this (if needed), you can find my ZSH config files at the following locations:

I use a fork of James Off's ZSH config that you can find over here

@MindTooth
Copy link
Member

I'm not sure how this is easily fixed. As changing the colors for kitty affects the whole system. I suspect that the only option if for you to change the colors in ZSH, and make it only affect it.

Tested setting the color you suggested, but then I had the recurring issue of other apps being affected.

@peschkaj
Copy link
Author

Thanks for looking into this. My terminal is largely just a terminal for running commands, so this one change works for me but I understand that it breaks things for others.

I'll look into changing the color just for ZSH, too, just in case I use more command line apps in the future. Thanks for that hint!

@MindTooth
Copy link
Member

I recommend Vim. 😉

Okay with you that I close the issue?

@peschkaj
Copy link
Author

I shall close this. Again: thanks for taking the time to look into this.

@roosta
Copy link
Member

roosta commented Jan 17, 2020

This issue should now be properly resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants