This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Feature/new packfile parser #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumbing/format/idxfile/writer.go
Outdated
| "gopkg.in/src-d/go-git.v4/utils/binary" | ||
| ) | ||
|
|
||
| type object struct { |
There was a problem hiding this comment.
we already have Entry in this package with this exact same struct, maybe you can use that?
plumbing/format/idxfile/writer.go
Outdated
| crc uint32 | ||
| } | ||
|
|
||
| type objects []object |
There was a problem hiding this comment.
are we using the objects type for something specific (i don't see any methods for it)? If not, I'd say just go with []object (or []Entry)
There was a problem hiding this comment.
Nvm, saw the methods at the end of the file
|
Now it supports 64 bit offsets but needs more testing. Index checksum is already generated by the encoder. |
erizocosmico
approved these changes
Jul 20, 2018
erizocosmico
approved these changes
Jul 26, 2018
jfontan
force-pushed
the
feature/new-packfile-parser
branch
from
b2508e4
to
51b3671
Compare
Signed-off-by: Javi Fontan <[email protected]>
In one case it disables the cache and the other disables lookup when the scanner is not seekable. Could be added back later. Signed-off-by: Javi Fontan <[email protected]>
It's still not complete: * 64 bit offsets * IdxChecksum Signed-off-by: Javi Fontan <[email protected]>
Signed-off-by: Javi Fontan <[email protected]>
Signed-off-by: Javi Fontan <[email protected]>
Signed-off-by: Javi Fontan <[email protected]>
Signed-off-by: Javi Fontan <[email protected]>
This functionality may be moved elsewhere in the future but is needed now to fit filesystem.ObjectStorage and the new index. Signed-off-by: Javi Fontan <[email protected]>
Index is also automatically generated when OnFooter is called. Signed-off-by: Javi Fontan <[email protected]>
Now dotgit.PackWriter uses the new packfile.Parser and index. Signed-off-by: Javi Fontan <[email protected]>
jfontan
force-pushed
the
feature/new-packfile-parser
branch
from
51b3671
to
79f2494
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #896
It needs tests and index writer is still not complete:
Some improvements can be done changing the cache to hold byte slices and index by offset. We can also skip reading headers in
resolveDeltasphase.