Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Ignore missing references/objects on log --all #1067

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Ignore missing references/objects on log --all #1067

merged 2 commits into from
Feb 13, 2019

Conversation

ajnavarro
Copy link
Contributor

To mimic the actual standard git behavior, we must ignore references that are pointing to wrong/unexistent objects.

Signed-off-by: Antonio Jesus Navarro Perez [email protected]

plumbing/object/commit_walker.go Outdated Show resolved Hide resolved
To mimic the actual standard git behavior, we must ignore references that are pointing to wrong/unexistent objects.

Signed-off-by: Antonio Jesus Navarro Perez <[email protected]>
Signed-off-by: Antonio Jesus Navarro Perez <[email protected]>
@ajnavarro
Copy link
Contributor Author

@kuba-- done! and thanks for the tip!

Copy link
Contributor

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only question is
does the logic in for loop is OK? Because it's slightly non-consistent what we have outside the loop. I mean:

  • we break on EOF
  • we skip plumbing.ErrReferenceNotFound
  • we return on any other error

@ajnavarro
Copy link
Contributor Author

@kuba-- I think the logic is ok

@mcuadros mcuadros merged commit 4d8bd13 into src-d:master Feb 13, 2019
@ajnavarro ajnavarro deleted the fix/log-all-missing-objects branch February 13, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants