Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss only on frontier? #30

Open
rginpan opened this issue Oct 5, 2023 · 0 comments
Open

Loss only on frontier? #30

rginpan opened this issue Oct 5, 2023 · 0 comments

Comments

@rginpan
Copy link

rginpan commented Oct 5, 2023

Hi, still me.
I have question about the MSE loss calculation, in the paper you mantioned that the loss only calculate on the frontier pixels, but I check the

mask = labels["loss_masks"][:, 2:]
# Evaluate predictions only on mask = 1 regions
mask_sum = mask.sum(dim=3).sum(dim=2) + 1e-16  # (b, 1)

The mask is a whole floor map not the frontier pixel by visualization, so you calaucte on the entier floor map instead of frontier pixels, am I correct?

Besides, why there is no mask processing on area_pf loss?

area_pf_loss = self.area_loss_fn(area_preds, area_gts).mean()
loss = loss + area_pf_loss
losses["area_pf_loss"] = area_pf_loss.item()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant