PHP 8.0 | Generic/AssignmentInCondition: include match expressions

Allows the sniff to also check for assignments in condition in the condition part of a match expression. Includes unit test.
squizlabs · Feb 23, 2021 · 580e9de · 580e9de
1 parent 8b0137a
commit 580e9de
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/src/Standards/Generic/Sniffs/CodeAnalysis/AssignmentInConditionSniff.php b/src/Standards/Generic/Sniffs/CodeAnalysis/AssignmentInConditionSniff.php
@@ -60,6 +60,7 @@ public function register()
             T_SWITCH,
             T_CASE,
             T_WHILE,
+            T_MATCH,
         ];
 
     }//end register()

diff --git a/src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.inc b/src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.inc
@@ -91,3 +91,5 @@ while ( $sample = false ) {}
 
 if ($a = 123) :
 endif;
+
+match ($a[0] = 123) {};
diff --git a/src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.php b/src/Standards/Generic/Tests/CodeAnalysis/AssignmentInConditionUnitTest.php
@@ -74,6 +74,7 @@ public function getWarningList()
             88 => 1,
             90 => 1,
             92 => 1,
+            95 => 1,
         ];
 
     }//end getWarningList()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -91,3 +91,5 @@ while ( $sample = false ) {}

		if ($a = 123) :
		endif;

		match ($a[0] = 123) {};
-Original file line number
+Diff line change
@@ Expand Up / @@ -74,6 +74,7 @@ public function getWarningList() @@
 => 1,
 => 1,
 => 1,
+=> 1,
             ];
         }//end getWarningList()
@@ Expand Down @@