-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant loading and the project plugin language switcher don't work together #6582
Comments
Thanks for reporting. The problems stems from the fact that the relative alternate URLs are not correctly resolved after navigating down the tree, as they are not canonicalized. We'll fix that as part of the next instant loading rewrite. |
I've fixed this on a branch in Insiders. This branch will host the next iteration of instant loading that will fix all open bugs and add new capabilities. Please understand that this will take some time to get right, because instant loading is very complex because of the many possible combinations of cases there are. Once we got everything in its right place, we'll backport fixes (excluding new features) to the community edition. |
Fixes are now in #6662. Please check if the errors are now fixed when using this version in your project:
|
Released as part of 9.5.5. |
Thanks. Sorry for not testing the fix earlier. I've been quite busy with work and some private affairs, leaving me with little time for my hobby projects. |
No worries, I hope everything is working now! |
Just ran above scenario again:
Is something wrong on my system? By the way, even when I remove
|
I'm not able to reproduce. Does it happen with the same reproduction you've posted in the OP? |
Yes, same example.zip. To make sure I have a clean environment I deleted all containers and the mkdocs-material docker image.
Next, in the example directory:
The web site starts with the English home page.
This is the entire log for these actions:
I also checked what happens after a build.
Open the website and perform the same actions:
Is there anything on my system that I can check to give you more insight in what's happening? |
Hmm, that is so odd. It worked before, but I can clearly see the problem. I'm sorry for the inconvenience this is causing you. I'll look into it asap. |
I know where this is coming from. For the instant navigation refactoring, we needed to change the sitemap resolution, which now resolves all URLs to absolute destinations. This was identified to be necessary to not get problems on slow connections. My testing shows that |
Glad you found it. No hurry. I don't have a mission-critical website. It's just a personal website for hobby and blogging. |
Context
No response
Bug description
As soon as instant loading is added to a project, the navigation loses its way and ends up in 404 errors. I discovered this while using the language switcher, but I am not sure if it is related to the switcher, or if it is a general issue with the instant loading feature.
Related links
Reproduction
example.zip
Steps to reproduce
When instant loading is removed from the mkdocs.yml files, then everything works properly.
Browser
No response
Before submitting
The text was updated successfully, but these errors were encountered: