Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar missing in certain firefox browser #2339

Closed
4 of 5 tasks
htwangtw opened this issue Feb 24, 2021 · 14 comments
Closed
4 of 5 tasks

Search bar missing in certain firefox browser #2339

htwangtw opened this issue Feb 24, 2021 · 14 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@htwangtw
Copy link

I've found a bug and checked that ...

  • ... the problem doesn't occur with the default MkDocs template
  • ... the problem is not in any of my customizations (CSS, JS, template)
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

Search bar doesn't show up with mkdocs-material 7.0.0 rendered site.
This issue is redirected from bids-standard/bids-specification#744

Expected behavior

Firefox: 85.0.1
image

Actual behavior

This is what I see:
image

Same behaviour with https://squidfunk.github.io/mkdocs-material/
image

Steps to reproduce the bug

N/A

Package versions

See: https://github.com/bids-standard/bids-specification

Project configuration

See: https://github.com/bids-standard/bids-specification/blob/master/mkdocs.yml

System information

  • OS: Debian 10
  • Browser: Firefox 78.7.0esr (latest for Debian)
@squidfunk
Copy link
Owner

squidfunk commented Feb 24, 2021

Could you please check the developer console? I suspect that Firefox 78 is too old and is missing an ES6/7 feature we're using. Also please check if this issue is present with Material 6.2.8.

@squidfunk squidfunk added the needs input Issue needs further input by the reporter label Feb 24, 2021
@htwangtw
Copy link
Author

htwangtw commented Feb 24, 2021

The version of the website built with 6.2.8 is fine (https://bids-specification.readthedocs.io/en/bep-009/)
This is also 6.x (https://bids-specification.readthedocs.io/en/v1.4.1/)
Can you explain a bit more what should I check in the developer console?

@squidfunk
Copy link
Owner

squidfunk commented Feb 25, 2021

Thanks for testing 6.2.8. Please check whether there are any errors listed below the "Console" tab in the Firefox Developer Console. If unsure, consult another developer on your team to validate.

@htwangtw
Copy link
Author

htwangtw commented Feb 25, 2021

There are two messages when I check the BIDS website (https://bids-specification.readthedocs.io/en/stable/)
Error:

Uncaught SyntaxError: expected expression, got '='bundle.3981fc68.min.js:3:48064

This message is not listed as an error but I thought it might be relevant:

Server side search is disabled. readthedocs-doc-embed.js:1:28238

Just cross-checking with the official page of Material (https://squidfunk.github.io/mkdocs-material/), we got the same error as above, and an extra one:

Uncaught ReferenceError: document$ is not defined
    <anonymous> bundle.ts:40
    <anonymous> bundle.ts:49
bundle.ts:40
    <anonymous> bundle.ts:40
    <anonymous> bundle.ts:49

@squidfunk
Copy link
Owner

squidfunk commented Feb 25, 2021

Which website are you referring to? When I look at both links you posted in bids-standard/bids-specification#744, there are entirely different chunkhashes:

  • bundle.926459b3.min.js
  • bundle.4e3fea51.min.js

Please provide complete information, i.e. also attach the file for which this happens, or we have no possibility to debug this. If unsure, please consult a developer colleague.

@divansantana
Copy link

have same issue with 7.0.2

dev tools in my qutebrowser says:

Uncaught SyntaxError: Unexcted token '='
bundle.3981fc68.min.js:3

browser version:

qutebrowser v1.14.1
Git commit: 
Backend: QtWebEngine (Chromium 83.0.4103.122)
Qt: 5.15.2

Tried reload -f but didn't help.

@divansantana
Copy link

I think it might be a browser version thing. Some users report after upgrading browser it works.

@lyz-code
Copy link

I've got the same error here.

The developer console shows:

Uncaught SyntaxError: expected expression, got '=' bundle.4e3fea51.min.js:3:48067

I've reproduced it with the following browsers:

  • Firefox 78.5.0esr
  • Chromium 83.0.4103.116
  • Firefox Klar 8.4.0

So I'll roll out that this is a browser issue.

@squidfunk
Copy link
Owner

squidfunk commented Feb 26, 2021

The transpile target was es2020. 500d5e6 now sets it at es2015, which should fix the issues. Please try the latest master, so we can issue a bugfix release.

@squidfunk
Copy link
Owner

... you could also just check https://squidfunk.github.io/mkdocs-material/ – if that works, we can issue the release.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs input Issue needs further input by the reporter labels Feb 26, 2021
@htwangtw
Copy link
Author

The search bar is showing with Firefox 78.5.0esr.

@squidfunk
Copy link
Owner

Perfect, thanks!

@squidfunk
Copy link
Owner

Released as part of 7.0.3.

@effigies
Copy link

Thanks for the quick turnaround, @squidfunk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

5 participants